Use @_spi(Experimental) for experimental methods #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmkiley
added
the
breaking change ⚠️
macdrevx
reviewed
Sep 15, 2021
Comment on lines
+173
to
+176
| - Note: This method is marked as experimental. Annotate the import statement | ||
| for `MapboxMaps` with `@_spi(Experimental)` in order to use experimental methods. | ||
| */ | ||
| public func _source(withId id: String, type: Source.Type) throws -> Source { | ||
| @_spi(Experimental) public func source(withId id: String, type: Source.Type) throws -> Source { |
There was a problem hiding this comment.
I don't think this needs to be experimental anymore. (same for the corresponding layer method above). We could actually knock out another issue related to these APIs at the same time by removing the variants that don't take a type parameter.
There was a problem hiding this comment.
That said, let's defer this feedback to our audit of all experimental APIs.
macdrevx
reviewed
Sep 15, 2021
macdrevx
reviewed
Sep 15, 2021
macdrevx
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
Pull request checklist:
Summary of changes
This PR:
@_spi(Experimental)annotation to mark style methods as experimental. This means that in order to use these methods, you will need to annotate your import statement forMapboxMapswith@_spi(Experimental). (@_spi(Experimental) import MapboxMaps).User impact (optional)