Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gesture Manager Delegate methods #697

Merged
merged 17 commits into from
Sep 24, 2021
Merged

Update Gesture Manager Delegate methods #697

merged 17 commits into from
Sep 24, 2021

Conversation

jmkiley
Copy link
Contributor

@jmkiley jmkiley commented Sep 22, 2021 •
edited
Loading

PRs must be submitted under the terms of our Contributor License Agreement CLA.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-ios changelog: <changelog></changelog>.

Summary of changes

This PR:

  • Renames GestureManagerDelegate.gestureBegan(for:) to GestureManagerDelegate.gestureManager(_:didBegin:).
  • Adds delegate methods for when the gesture and drifts end to GestureHandlerDelegate and GestureManagerDelegate.

User impact (optional)

@jmkiley jmkiley added the breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published label Sep 22, 2021
@jmkiley jmkiley self-assigned this Sep 22, 2021
neelmistry94
neelmistry94 reviewed Sep 22, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jmkiley jmkiley force-pushed the jk/gesture-manaager-delegate branch 2 times, most recently from f37d595 to 792af8b Compare September 22, 2021 19:53
@jmkiley jmkiley changed the base branch from feature/gestures_cleanup to main September 22, 2021 19:53
macdrevx
macdrevx suggested changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@macdrevx macdrevx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on the right track. I haven't reviewed tests yet, but let's address this batch of feedback first.

Sources/MapboxMaps/Gestures/GestureHandlers/GestureHandler.swift Outdated Show resolved Hide resolved
Sources/MapboxMaps/Gestures/GestureHandlers/PanGestureHandler.swift Outdated Show resolved Hide resolved
Sources/MapboxMaps/Gestures/GestureManager.swift Outdated Show resolved Hide resolved
Sources/MapboxMaps/Gestures/GestureManager.swift Outdated Show resolved Hide resolved
@macdrevx macdrevx mentioned this pull request Sep 24, 2021
Merged
8 tasks
Jordan Kiley added 10 commits September 24, 2021 11:48
Add delegate methods for gesture began and gestudre ended
ccd2d70 
Update so double tap calls end method immediately

Add driftEnded

Begin to update mock GestureManager and GestureHandlers

Update pan and double tap gesture tests

Update pinch tests

Update pitch tests, assert if willDecelerate is false/true instead of equal

Update tests for rotate and quick zoom, fix typos

Add link to CHANGELOG

Set .began to ended in rorate tests

Update docs
remove files that were readded during rebase
cee3a9e
Update for double tap and double touch to zoom
ea6c931
Update stray GestureTypes for double touch/tap
d2f30e5
Completion should not be nil for double tap/touch
6c957af
Update docs for gestureManager(didBegin)
a9e58f1
Use willAnimate rather than willDecelerate
4481cda
Update calls for when pan gesture ended
6e09354
Move where call pan ended with animation
fba789a
rename remaining drift methods
1742f6f
macdrevx
macdrevx reviewed Sep 24, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jmkiley @macdrevx
Update CHANGELOG.md
0b80685 
Co-authored-by: Andrew Hershberger <andrew.hershberger@mapbox.com>
@jmkiley jmkiley merged commit be084c5 into main Sep 24, 2021
@jmkiley jmkiley deleted the jk/gesture-manaager-delegate branch September 24, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neelmistry94 neelmistry94 neelmistry94 approved these changes

@macdrevx macdrevx macdrevx approved these changes

Assignees

@jmkiley jmkiley

Labels
breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmkiley @macdrevx @neelmistry94