Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TileRegionLoadOptions to use turf geometry #711

Merged
merged 7 commits into from
Sep 28, 2021
Merged

Update TileRegionLoadOptions to use turf geometry #711

merged 7 commits into from
Sep 28, 2021

Conversation

neelmistry94
Copy link
Contributor

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'

Summary of changes

Expose Geometry for TileRegionLoadOptions as a Turf Geometry

@neelmistry94 neelmistry94 added the breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published label Sep 27, 2021
@macdrevx
Copy link
Contributor

Would like to see some unit tests

@neelmistry94 neelmistry94 enabled auto-merge (squash) September 27, 2021 20:51
@1ec5 1ec5 mentioned this pull request Sep 28, 2021
Merged
@neelmistry94 neelmistry94 force-pushed the nm/tileRegionLoadOptions_for_turf branch from 32139ae to 153d99e Compare September 28, 2021 15:53
@neelmistry94 neelmistry94 merged commit f439f2b into main Sep 28, 2021
@neelmistry94 neelmistry94 deleted the nm/tileRegionLoadOptions_for_turf branch September 28, 2021 20:47
OdNairy pushed a commit that referenced this pull request Aug 22, 2023
Merge pull request #711 from mapbox/nm/update_release_template_docs
8221468 
update issue template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macdrevx macdrevx macdrevx approved these changes

Assignees
No one assigned
Labels
breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neelmistry94 @macdrevx