Work around pan deceleration on pitched maps #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macdrevx
added
the
skip changelog
@macdrevx Is there a ticket for this bug? If not yet I can open one and will check it later in gl-native. |
macdrevx
force-pushed
the
ah/pan-deceleration-workaround
branch
from
b572f66
to
07d5dd1
Compare
macdrevx
commented
Oct 20, 2021
Sources/MapboxMaps/Gestures/GestureHandlers/PanGestureHandler.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
Summary of changes
When the map is pitched, pan gestures may cause unexpectedly large changes during deceleration. This is a bug in the underlying drag API, but until that is fixed, we're introducing a workaround that causes the deceleration to happen more quickly or be skipped altogether on pitched maps. This implementation is an adaptation of the ideas in mapbox/mapbox-maps-android#754 although that approach does not apply exactly since pan deceleration is implemented differently on iOS.
Before:
Before.mp4
After:
After.mp4