[examples] Add SwiftUI example #78
Conversation
|
|
|
I pushed a commit with some updates that I worked on today and went over with @captainbarbosa. I need to add some additional explanatory comments to the example before this is merged. My commit also removes the annotations aspect of the example. I'd like to review that part with @julianrex and @nishant-karajgikar to see if we can come up with something a bit more declarative. |
macdrevx
force-pushed
the
nb/swiftui-example
branch
from
8e51a9d to
529cbe9
Compare
| public enum StyleURL { | ||
| public enum StyleURL: Hashable { |
There was a problem hiding this comment.
This is a minor SDK modification which made the example easier to write.
|
@julianrex @ZiZasaurus this is ready for re-review. Please read the documentation I added to make sure it is clear. Let me know if you'd like to chat about it. |
macdrevx
force-pushed
the
nb/swiftui-example
branch
from
529cbe9 to
959067d
Compare
macdrevx
force-pushed
the
nb/swiftui-example
branch
from
959067d to
0685168
Compare
| /// We configure the slider to bind to the camera's zoom. Adjusting the slider with | ||
| /// change the zoom on the map, and changing the zoom by interacting with the map | ||
| /// will change the slider. Here's the data flow: | ||
| /// | ||
| /// Slider to Map: | ||
| /// - User interacts with the slider | ||
| /// - Slider updates the camera binding's zoom value |
There was a problem hiding this comment.
Did something happen with indents here?
There was a problem hiding this comment.
This is how Xcode likes it. The comments are aligned to the indentation of the next line of code.
| /// Slider to Map: | ||
| /// - User interacts with the slider | ||
| /// - Slider updates the camera binding's zoom value | ||
| /// - SwiftUI invokes `updateUIView(_:context:)` on `SwiftUIMapView` | ||
| /// - `SwiftUIMapView` reads the updated camera zoom value and sets it on the underlying `MapView` | ||
| /// | ||
| /// Map to Slider: | ||
| /// - User interacts with the map, adjusting the zoom | ||
| /// - Map sends the `.cameraDidChange` event, which is observed by the coordinator | ||
| /// - The coordinator updates the value of the zoom on the `camera` binding | ||
| /// - SwiftUI updates the Slider accordingly |
There was a problem hiding this comment.
Thanks for clarifying the flow here - definitely helps
| public enum StyleURL { | ||
| public enum StyleURL: Hashable { |
macdrevx
force-pushed
the
nb/swiftui-example
branch
from
5cf2afd to
8cede27
Compare
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Pull request checklist:
mapbox-maps-ioschangelog:<changelog>Added SwiftUI example.</changelog>.Summary of changes
Adds a new example that illustrates how to wrap a
MapViewinside a SwiftUI view.cc @mapbox/maps-ios