Investigate routes blinking when selecting alternatives

[Guardiola31337]

As commented in #2452 (review)

Noticed a blinking behavior when switching routes when running the SimpleMapboxNavigationKt example from the examples test app 👀

Thought that was fixed in #2262

Maybe a different setup for SimpleMapboxNavigationKt?

cc @LukasPaczos @kmadsen

[Guardiola31337]

Maybe we can fix as part of #2464? cc @RingerJK

[RingerJK]

@Guardiola31337 I'll take a look, but if it leads to make huge changes better do fix in separate PR

[LukasPaczos]

The issue is with a way we set the DirectionsRoute into the legacy NavigationMapRoute. Right now, we're calling navigationMapRoute?.addRoutes(routes) which is going to completely redraw the layers.

NavigationMapRoute#addRoutes should internally check if the provided DirectionsRoutes references are the same but the in a different order and only change the underlying GeoJsonSources instead of always redrawing all of the layers.

[Guardiola31337]

@RingerJK

I'll take a look, but if it leads to make huge changes better do fix in separate PR

Of course! I wanted to put this on your radar so you could 👀 as you're working on #2464 🍍

[Guardiola31337]

The issue is with a way we set the DirectionsRoute into the legacy NavigationMapRoute. Right now, we're calling navigationMapRoute?.addRoutes(routes) which is going to completely redraw the layers.

NavigationMapRoute#addRoutes should internally check if the provided DirectionsRoutes references are the same but the in a different order and only change the underlying GeoJsonSources instead of always redrawing all of the layers.

That makes sense. Thanks for clarifying @LukasPaczos 🙇