Skip to content

Conversation

danesfeder
Copy link
Contributor

Fixes #1721

We were only allowing simulation of the first route with the NavigationView. This was because with the new location APIs, we need to re-request updates in order for the simulation to begin.

I took this opportunity to make LocationEngineConductor package-private as well. I don't believe this class needs to be public as it's used internally in the NavigationView.

@codecov-io
Copy link

Codecov Report

Merging #1724 into master will increase coverage by 0.01%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master    #1724      +/-   ##
============================================
+ Coverage     29.27%   29.29%   +0.01%     
- Complexity      821      823       +2     
============================================
  Files           212      212              
  Lines          8045     8050       +5     
  Branches        626      626              
============================================
+ Hits           2355     2358       +3     
  Misses         5465     5465              
- Partials        225      227       +2

Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @danesfeder 🚀

@danesfeder danesfeder merged commit 1bdf9d7 into master Feb 5, 2019
@danesfeder danesfeder deleted the dan-replay-engine branch February 5, 2019 16:42
@Guardiola31337 Guardiola31337 mentioned this pull request Feb 13, 2019
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards incompatible Requires a SEMVER major version change. bug Defect to be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants