Refactoring trigger-mobile-metrics script for updated notifications #6844
Conversation
ChangelogFeaturesBug fixes and improvements
Known issues
|
Codecov Report
@@ Coverage Diff @@
## main #6844 +/- ##
=========================================
Coverage 72.64% 72.64%
Complexity 5564 5564
=========================================
Files 781 781
Lines 30116 30116
Branches 3561 3561
=========================================
Hits 21878 21878
Misses 6810 6810
Partials 1428 1428 |
|
|
||
| trigger_workflow(token, commit, publish_results) | ||
|
|
||
| if not publish_results: |
There was a problem hiding this comment.
What happened to the branch where publish_results is True?
There was a problem hiding this comment.
These jobs will be called by running the workflow with run_android_navigation_benchmark flag
There was a problem hiding this comment.
What do you mean? Why don't we publish results anymore?
| trigger_workflow(token, commit, publish_results) | ||
|
|
||
| if not publish_results: | ||
| trigger_job(token, commit, "android-navigation-code-coverage-ci") |
There was a problem hiding this comment.
it's not clear what happens if publish_results == false, the script trigger workflow and additionally triggered jobs, right?
|
Okay, I need to write more detailed information about what happens here. Early this script ran:on the main branch:
on other branches:
After refactoring:on the main branch:
on other branches:
As you can see, nothing was changed in general. These changes are only for changed jobs/workflow structure in mobile-metrics. |
|
@SevaZhukov I get it. Thanks. Do you know if we run * |
@RingerJK The |
https://mapbox.atlassian.net/browse/NAVSDK-216
These changes are necessary after mobile-metrics repository refactoring. We can't continue to trigger jobs because we need to set the context for sending notifications using Slack Orb. This we can implement only using workflows triggering.