-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android Auto] Optimized SpeedLimitWidget memory usage #6859
Merged
tomaszrybakiewicz
merged 3 commits into
main
from
NAVAND-1009_tr-android-auto_speed_limit_render_optimization
Jan 23, 2023
Merged
[Android Auto] Optimized SpeedLimitWidget memory usage #6859
tomaszrybakiewicz
merged 3 commits into
main
from
NAVAND-1009_tr-android-auto_speed_limit_render_optimization
Jan 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ruBitmapPool - Moved SpeedLimitWidget draw logic to separate Drawable classes.
tomaszrybakiewicz
added
Android Auto
Bugs, improvements and feature requests on Android Auto.
improvement
Improvement for an existing feature.
labels
Jan 20, 2023
ChangelogFeatures
Bug fixes and improvements
Known issues
|
Codecov Report
@@ Coverage Diff @@
## main #6859 +/- ##
=========================================
Coverage 72.68% 72.68%
Complexity 5576 5576
=========================================
Files 783 783
Lines 30186 30186
Branches 3571 3571
=========================================
Hits 21941 21941
Misses 6819 6819
Partials 1426 1426 |
kmadsen
reviewed
Jan 20, 2023
...dauto/src/main/java/com/mapbox/androidauto/navigation/speedlimit/SpeedLimitBitmapProvider.kt
Outdated
Show resolved
Hide resolved
kmadsen
reviewed
Jan 20, 2023
...androidauto/src/main/java/com/mapbox/androidauto/navigation/speedlimit/SpeedLimitDrawable.kt
Show resolved
Hide resolved
kmadsen
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor comments but thanks for updating! Big improvement on the class organization
…er -> SpeedLimitBitmapRenderer. Moved MutcdSpeedLimitDrawable and ViennaSpeedLimitDrawable to separate files
tomaszrybakiewicz
deleted the
NAVAND-1009_tr-android-auto_speed_limit_render_optimization
branch
January 23, 2023 16:42
This was referenced Jan 24, 2023
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Android Auto
Bugs, improvements and feature requests on Android Auto.
improvement
Improvement for an existing feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes NAVAND-1009
Description
LruBitmapPool
LruBitmapPool
has been configured to hold only 2 bitmaps - one for VIENNA and one for MUTC signViennaSpeedLimitDrawable
for theSpeedLimitSign.VIENNA
MutcdSpeedLimitDrawable
for theSpeedLimitSign.MUTCD