Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android Auto] Optimized SpeedLimitWidget memory usage #6859

Conversation

tomaszrybakiewicz
Copy link
Contributor

Closes NAVAND-1009

Description

  • Optimized SpeedLimitWidget Bitmap usage by utilizing LruBitmapPool
    • The LruBitmapPool has been configured to hold only 2 bitmaps - one for VIENNA and one for MUTC sign
  • Moved SpeedLimitWidget draw logic to separate Drawable classes
    • ViennaSpeedLimitDrawable for the SpeedLimitSign.VIENNA
    • MutcdSpeedLimitDrawable for the SpeedLimitSign.MUTCD

…ruBitmapPool

- Moved SpeedLimitWidget draw logic to separate Drawable classes.
@tomaszrybakiewicz tomaszrybakiewicz added Android Auto Bugs, improvements and feature requests on Android Auto. improvement Improvement for an existing feature. labels Jan 20, 2023
@github-actions
Copy link

github-actions bot commented Jan 20, 2023

Changelog

Features

  • Added MapboxTripStarter to simplify the solution for managing the trip session and replaying routes. This also makes it possible to share the replay state between drop-in-ui and android-auto. #6794

Bug fixes and improvements

  • Increased max distance from the user indicator to route line valid to continue vanishing updates from 3m to 10m. #6854
  • Fixed an issue where alternative routes might have had an incorrect or incomplete portion of the route refreshed or occasionally fail to refresh. #6848
  • Removed NavigationRoute#hasUnexpectedClosures and added RouteProgress#hasUnexpectedUpcomingClosures instead that checks whether route has upcoming unexpected closures (the algorithm does not take into account closures that the puck has already been on) #6841
  • Improved NavigationView camera behavior to go back into overview state if routes change during route preview state. #6840

Known issues ⚠️

Other changes

Android Auto Changelog

Features

  • Added support for Junction Views. #6849

Bug fixes and improvements

  • Optimized SpeedLimitWidget memory usage. #6859

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #6859 (321e5be) into main (5f67450) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #6859   +/-   ##
=========================================
  Coverage     72.68%   72.68%           
  Complexity     5576     5576           
=========================================
  Files           783      783           
  Lines         30186    30186           
  Branches       3571     3571           
=========================================
  Hits          21941    21941           
  Misses         6819     6819           
  Partials       1426     1426           

Copy link
Contributor

@kmadsen kmadsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor comments but thanks for updating! Big improvement on the class organization

…er -> SpeedLimitBitmapRenderer. Moved MutcdSpeedLimitDrawable and ViennaSpeedLimitDrawable to separate files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Auto Bugs, improvements and feature requests on Android Auto. improvement Improvement for an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants