Fix Proguard issues #825
Fix Proguard issues #825
Conversation
Guardiola31337
force-pushed
the
pg-824-proguard-issues
branch
from
bc88558 to
d0a9712
Compare
| @@ -18,8 +18,7 @@ android { | |||
| testCoverageEnabled = false | |||
| } | |||
| release { | |||
| minifyEnabled false | |||
| proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro' | |||
There was a problem hiding this comment.
Should we be removing the proguard file here? Will our rules still be tested if we do?
There was a problem hiding this comment.
Should we be removing the proguard file here?
Yeah, we're not including any specific Proguard rules for the test app.
Will our rules still be tested if we do?
Yeah, this is managed by consumerProguardFiles. BTW you can check the build and 👀 that Proguard is running and working https://circleci.com/gh/mapbox/mapbox-navigation-android/3875?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link (Build release to test ProGuard rules step)
There was a problem hiding this comment.
@Guardiola31337 awesome, thanks for the clarification and quick turn around on this
|
Here are the proguard rules (coming from MAS) that worked for MapsSdkTestApp |
Adds Proguard rules to
libandroid-navigationandlibandroid-navigation-uiso that builds with Proguard enabled don't fail.Adds a step to the CI build to attempt to check if Proguard rules work.
Fixes Proguard Release Build Fails #824
👀 @danesfeder @devotaaabel