Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodically refresh the route with the latest traffic and ETAs #2284

Closed
1ec5 opened this issue Dec 7, 2019 · 2 comments · Fixed by #2366
Closed

Periodically refresh the route with the latest traffic and ETAs #2284

1ec5 opened this issue Dec 7, 2019 · 2 comments · Fixed by #2366
Assignees
Labels
feature New feature request. op-ex Refactoring, Tech Debt or any other operational excellence work. platform parity Required to keep on par with Android. topic: directions
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Dec 7, 2019

During turn-by-turn navigation, the SDK should periodically update the current route’s attributes and ETAs to reflect changing traffic conditions.

A specialized Directions API returns a sparse response that we’ll need to merge into the existing route and route progress models. This will require the ability to mutate the route model without recreating it from scratch. Currently most of the properties in Route, RouteLeg, etc. are constant. MapboxDirections.swift could define mutable subclasses, or define these types to structures that come with mutability built-in, or implement built-in methods for merging in updated data.

The route refreshing feature will complement two other forms of updates the SDK already performs: proactive rerouting periodically checks for a more optimal route than the current one, while ETA refreshing simply updates the ETA to reflect whether the user is keeping pace.

This feature has already been implemented on Android in mapbox/mapbox-navigation-android#1855.

/cc @mapbox/navigation-ios

@1ec5 1ec5 added platform parity Required to keep on par with Android. op-ex Refactoring, Tech Debt or any other operational excellence work. feature New feature request. topic: directions labels Dec 7, 2019
@1ec5 1ec5 modified the milestones: v1.0.0, v0.x next Apr 14, 2020
@1ec5 1ec5 added blocked Blocked by dependency or unclarity. size: M labels Apr 14, 2020
@Udumft Udumft self-assigned this Apr 20, 2020
@Udumft
Copy link
Contributor

Udumft commented Apr 21, 2020

mapbox/mapbox-navigation-android#1855 seems to be outdated implementation. Rote Refreshing was updated on Android in 1.0 in Nav SDK #2570 to match it's current API structure

@1ec5 1ec5 modified the milestones: v0.40.0, v1.0.0 Apr 24, 2020
@1ec5 1ec5 removed the blocked Blocked by dependency or unclarity. label Apr 24, 2020
@1ec5
Copy link
Contributor Author

1ec5 commented Aug 31, 2020

An implementation is moving in mapbox/mapbox-directions-swift#420 and #2366. Testing is currently blocked by #2574.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request. op-ex Refactoring, Tech Debt or any other operational excellence work. platform parity Required to keep on par with Android. topic: directions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants