Route Refresh #2366
Merged
Route Refresh #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Udumft
added
platform parity
|
Discussed today with Antonio and Hossam. Not a release blocker for v1.0 marketing push. We will backport to v1.0 branch and include as part of v1.0.x |
|
Removed the release blocker sticker. |
1ec5
force-pushed
the
2284-route-refresh
branch
from
224741e
to
893f57f
Compare
1ec5
reviewed
Sep 2, 2020
|
I expanded the scope of this PR in #2591. If approved, that PR would merge into this one and we’d be pretty close to landing the feature. |
1ec5
reviewed
Sep 2, 2020
1ec5
force-pushed
the
2284-route-refresh
branch
from
893f57f
to
e0df11d
Compare
…tal idea about RouteProgress route refreshing.
1ec5
force-pushed
the
2284-route-refresh
branch
from
e0df11d
to
6103287
Compare
Keep track of the route’s index in the overall route response and use it when refreshing the route. Added a route index argument to a litany of public and private methods and initializers. Explicitly merge the skeletal refreshed route into the original route.
Post a notification and inform the navigation service and navigation view controller delegates whenever the route is refreshed. On refresh, update the route line to reflect the new traffic congestion data.
1ec5
approved these changes
Sep 3, 2020
1ec5
added
the
backwards incompatible
|
I missed a couple spots when adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traffic congestion segments along the route line and the estimated arrival time periodically update to reflect current conditions when using the
DirectionsProfileIdentifier.automobileAvoidingTrafficprofile. These updates correspond to the newNotification.Name.routeControllerDidRefreshRoutenotification,NavigationServiceDelegate.navigationService(_:didRefresh:)method, andNavigationViewControllerDelegate.navigationViewController(_:didRefresh:)method. To disable these updates, setRouteOptions.refreshingEnabledtofalse.The
NavigationViewController.routeandNavigationService.routeproperties are now read-only. To change the route that the user is traveling along, set theNavigationViewController.indexedRouteorNavigationService.indexedRouteproperty instead, pairing the route with the index of the route in the originalRouteResponseobject.The following methods now require a route index to be passed in as an argument:
NavigationViewController(for:routeIndex:routeOptions:navigationOptions:)NavigationViewController(route:routeIndex:routeOptions:navigationService:)CarPlayManagerDelegate.carPlayManager(_:navigationServiceAlong:routeIndex:routeOptions:desiredSimulationMode:)MapboxNavigationService(route:routeIndex:routeOptions:)MapboxNavigationService(route:routeIndex:routeOptions:directions:locationSource:eventsManagerType:simulating:routerType:)RouteProgress(route:routeIndex:options:legIndex:spokenInstructionIndex:)RouteProgress(route:routeIndex:options:legIndex:spokenInstructionIndex:)Router(along:routeIndex:options:directions:dataSource:)RouteController(along:routeIndex:options:directions:dataSource:)Resolves #2284
Work-In-Progress
So far added basic implementation for calling Route Refresh. Experimenting with
RouteProgressto refresh it's Route contents (suggestions are welcome).Thinking about route refresh period setting to be related with better route search period