Sub Instruction and lane component instructions integration tests #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext MapboxDirections.Swift release.
# Conflicts: # MapboxNavigation/VisualInstructionComponent.swift # MapboxNavigationTests/InstructionsBannerViewIntegrationTests.swift # MapboxNavigationTests/InstructionsBannerViewSnapshotTests.swift # MapboxNavigationTests/ReferenceImages_64/MapboxNavigationTests.InstructionsBannerViewSnapshotTests/testAbbreviateInstructionsIncludingDelimiter@3x.png
akitchen
reviewed
May 21, 2018
|
|
||
| //the delimiter should NOT be present since both shields are already in the cache | ||
| //the delimiter should NOT be present since both shields are already niin the cache |
There was a problem hiding this comment.
Look like a typo slipped in here
… components. Removed none case in Visual Instruction Component. Corrected typo.
vincethecoder
changed the title
|
Upon the completion of tests for the parent Direction PR, I will re-open this PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds necessary tests for the new
subinstructions andlanecomponent.Addresses mapbox/mapbox-directions-swift#258