Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip roundabout if it's left-hand rule of the road #1639

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Flip roundabout if it's left-hand rule of the road #1639

merged 1 commit into from
Aug 30, 2018

Conversation

frederoni
Copy link
Contributor

@frederoni frederoni commented Aug 30, 2018 •
edited
Loading

Fixes #1637 Unflip roundabout icons

Looks like this regressed in #1514

cc @vincethecoder @bsudekum @1ec5 @margvl

@margvl
Copy link

margvl commented Aug 30, 2018

I think this issue can effect uTurn as well but I have not tested it

@frederoni frederoni mentioned this pull request Aug 30, 2018
Closed
@frederoni
Copy link
Contributor Author

frederoni commented Aug 30, 2018 •
edited
Loading

I think this issue can effect uTurn as well but I have not tested it

@margvl you're right, u-turns were drawn according to the opposite rule of the road as well. Fixed in fb87d1c will fix this in a separate PR.

@frederoni frederoni merged commit 51e18a6 into master Aug 30, 2018
@frederoni frederoni deleted the fred/roundabout-driving-side branch August 30, 2018 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincethecoder vincethecoder vincethecoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frederoni @margvl @vincethecoder