Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation camera viewport API. #2826

Merged
merged 72 commits into from
Apr 13, 2021
Merged

Navigation camera viewport API. #2826

merged 72 commits into from
Apr 13, 2021

Commits on Mar 23, 2021

  1. Add initial version of Navigation Viewport Camera API.

    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    ff65ef0 View commit details
    Browse the repository at this point in the history

  2. Replace NavigationCameraStateObserver with NSNotification.

    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    98254fc View commit details
    Browse the repository at this point in the history

  3. Update only user puck when arriving to highlighted building.

    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    8d75a02 View commit details
    Browse the repository at this point in the history

  4. Remove NavigationMapViewCourseTrackingDelegate.

    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    8d91b36 View commit details
    Browse the repository at this point in the history

  5. Update CustomViewController to new camera behavior.

    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    7850866 View commit details
    Browse the repository at this point in the history

  6. Add ability to cancel pending camera transitions.

    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    6766e5d View commit details
    Browse the repository at this point in the history

  7. Add array extensions required for transitions.

    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    cb2147c View commit details
    Browse the repository at this point in the history

  8. Add basic implementation of transitions functionality.

    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    d576504 View commit details
    Browse the repository at this point in the history

  9. Simplify transition completion.

    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    e32c678 View commit details
    Browse the repository at this point in the history

  10. Fix issue related to incorrect camera positioning right before maneuver.

    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    35ff55e View commit details
    Browse the repository at this point in the history

  11. Improve UserCourseView handling during camera transitions.

    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    91786ec View commit details
    Browse the repository at this point in the history

  12. Refactor NavigationViewportDataSource to simplify CameraOptions c… 

    …alculations.
    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    2c0fbf8 View commit details
    Browse the repository at this point in the history

  13. Add NavigationCameraDebugView to be able to debug viewport related … 

    …changes. Refactor `NavigationViewportDataSource` to simplify underlying logic.
    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    4007e68 View commit details
    Browse the repository at this point in the history

  14. Improve UserCourseView updates when running long animations. Improv… 

    …e camera behavior when building highlighting is enabled.
    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    fab68e9 View commit details
    Browse the repository at this point in the history

  15. Make frame by frame UserCourseView location updates default.

    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    3caf811 View commit details
    Browse the repository at this point in the history

  16. Simplify NavigationCameraStateTransition.

    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    7a60c97 View commit details
    Browse the repository at this point in the history

  17. Fix crash in CameraView in case if location is invalid.

    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    0956c59 View commit details
    Browse the repository at this point in the history

  18. Improve viewport padding related issues.

    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    8ea2d04 View commit details
    Browse the repository at this point in the history

  19. Improve notifications handling in NavigationCameraDebugView.

    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    d1d7315 View commit details
    Browse the repository at this point in the history

  20. Rename method.

    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    24c5a3e View commit details
    Browse the repository at this point in the history

  21. Introduce ViewportDataSourceType to be able to control what locatio… 

    …ns should be retrieved by `NavigationViewportDataSource`.
    @MaximAlien
    MaximAlien committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    d6b60fb View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Integrate Mapbox Maps CameraView and CameraAnimator. (#2886)

    @MaximAlien
    MaximAlien authored Mar 30, 2021
    Configuration menu
    Copy the full SHA
    203601c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release-v2.0' into maxim/camera-viewport-api 

    # Conflicts:
#	Example/CustomViewController.swift
#	Example/ViewController.swift
#	Sources/MapboxNavigation/CarPlayManager.swift
#	Sources/MapboxNavigation/CarPlayMapViewController.swift
#	Sources/MapboxNavigation/CarPlayNavigationViewController.swift
#	Sources/MapboxNavigation/NavigationMapView.swift
#	Sources/MapboxNavigation/NavigationViewController.swift
#	Sources/MapboxNavigation/RouteMapViewController.swift
    @MaximAlien
    MaximAlien committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    f26520e View commit details
    Browse the repository at this point in the history

  3. Improve indentation.

    @MaximAlien
    MaximAlien committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    9c02e73 View commit details
    Browse the repository at this point in the history

  4. Add ability to use PassiveLocationManager on CarPlay.

    @MaximAlien
    MaximAlien committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    ded2563 View commit details
    Browse the repository at this point in the history

  5. Improve camera viewport related issues on iOS and CarPlay.

    @MaximAlien
    MaximAlien committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    a06b8eb View commit details
    Browse the repository at this point in the history

  6. Add more debugging instruments.

    @MaximAlien
    MaximAlien committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    81812a2 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. Minor improvements.

    @MaximAlien
    MaximAlien committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    7b2ed48 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release-v2.0' into maxim/camera-viewport-api 

    # Conflicts:
#	Sources/MapboxNavigation/NavigationMapView.swift
    @MaximAlien
    MaximAlien committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    876093b View commit details
    Browse the repository at this point in the history

  3. Resolve outstanding conflicts in CocoaPodsTest.

    @MaximAlien
    MaximAlien committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    41093db View commit details
    Browse the repository at this point in the history

  4. Minor properties renaming.

    @MaximAlien
    MaximAlien committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    aad725f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'release-v2.0' into maxim/camera-viewport-api

    @MaximAlien
    MaximAlien committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    f2d5268 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. Set initial coordinate for active guidance navigation on CarPlay.

    @MaximAlien
    MaximAlien committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    d0497d8 View commit details
    Browse the repository at this point in the history

  2. Update changelog and jazzy docs.

    @MaximAlien
    MaximAlien committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    38d9827 View commit details
    Browse the repository at this point in the history

  3. Minor improvements in camera transitions.

    @MaximAlien
    MaximAlien committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    e32f4dd View commit details
    Browse the repository at this point in the history

  4. Fix camera related issues in CustomViewController.

    @MaximAlien
    MaximAlien committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    f59cb67 View commit details
    Browse the repository at this point in the history

  5. Make NavigationCameraDebugView part of MapboxNavigation to simplify… 

    … its usage on client side.
    @MaximAlien
    MaximAlien committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    fdc8724 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'release-v2.0' into maxim/camera-viewport-api

    @MaximAlien
    MaximAlien committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    8a28635 View commit details
    Browse the repository at this point in the history

  7. Update jazzy docs.

    @MaximAlien
    MaximAlien committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    c513aaf View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2021

  1. Add more information to navigation camera debugging view.

    @MaximAlien
    MaximAlien committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    cfb8516 View commit details
    Browse the repository at this point in the history

  2. Further improvements to make debugging easier.

    @MaximAlien
    MaximAlien committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    c9d698e View commit details
    Browse the repository at this point in the history

  3. Fix padding in active guidance for CarPlay.

    @MaximAlien
    MaximAlien committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    2e2a348 View commit details
    Browse the repository at this point in the history

  4. Make navigationViewportDataSource weak.

    @MaximAlien
    MaximAlien committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    6ad741f View commit details
    Browse the repository at this point in the history

  5. Fix issues related to fitting camera on CarPlay while previewing rout… 

    …es and during active guidance.
    @MaximAlien
    MaximAlien committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    5714845 View commit details
    Browse the repository at this point in the history

  6. Fix issue related to switching between overview and following modes o… 

    …n CarPlay.
    @MaximAlien
    MaximAlien committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    0e41bac View commit details
    Browse the repository at this point in the history

  7. Use non-zero padding in overview mode on CarPlay.

    @MaximAlien
    MaximAlien committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    0f462de View commit details
    Browse the repository at this point in the history

  8. Merge branch 'release-v2.0' into maxim/camera-viewport-api

    @MaximAlien
    MaximAlien committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    cd4aad2 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2021

  1. Remove the ability to control visibility of `NavigationCameraDebugVie… 

    …w` via public API.
    @MaximAlien
    MaximAlien committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    6e5dca7 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Remove custom implementations of navigation camera as they were moved… 

    … to separate example.
    @MaximAlien
    MaximAlien committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    8340599 View commit details
    Browse the repository at this point in the history

  2. Improve PassiveLocationDataSource management.

    @MaximAlien
    MaximAlien committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    a019037 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. Fix issue, which was causing incorrect position of camera on CarPlay … 

    …during active guidance.
    @MaximAlien
    MaximAlien committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    cd82049 View commit details
    Browse the repository at this point in the history

  2. Improve NavigationCameraDebugView drawing.

    @MaximAlien
    MaximAlien committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    4410a3b View commit details
    Browse the repository at this point in the history

  3. Fix issue, which was causing incorrect camera behavior on CarPlay in … 

    …overview mode.
    @MaximAlien
    MaximAlien committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    1edae74 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. Merge branch 'release-v2.0' into maxim/camera-viewport-api 

    # Conflicts:
#	Sources/MapboxNavigation/RouteMapViewController.swift
    @MaximAlien
    MaximAlien committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    1360d07 View commit details
    Browse the repository at this point in the history

  2. Fix memory leak in NavigationMapView.

    @MaximAlien
    MaximAlien committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    3cc94c5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'release-v2.0' into maxim/camera-viewport-api

    @MaximAlien
    MaximAlien committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    77e68c8 View commit details
    Browse the repository at this point in the history

  4. Address code review feedback.

    @MaximAlien
    MaximAlien committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    3de06ff View commit details
    Browse the repository at this point in the history

  5. Remove excessive CLLocation extension.

    @MaximAlien
    MaximAlien committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    6900f49 View commit details
    Browse the repository at this point in the history

  6. Address code review feedback.

    @MaximAlien
    MaximAlien committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    4e47417 View commit details
    Browse the repository at this point in the history

  7. Update FrameIntervalOptions.

    @MaximAlien
    MaximAlien committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    56cd738 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'release-v2.0' into maxim/camera-viewport-api

    @MaximAlien
    MaximAlien committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    8bb685d View commit details
    Browse the repository at this point in the history

  9. Update changelog.

    @MaximAlien
    MaximAlien committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    578b705 View commit details
    Browse the repository at this point in the history

  10. Disable debugging view, improve comments.

    @MaximAlien
    MaximAlien committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    c4ae428 View commit details
    Browse the repository at this point in the history

  11. Fix issue related to incorrect UserCourseView bearing.

    @MaximAlien
    MaximAlien committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    1f60266 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'release-v2.0' into maxim/camera-viewport-api

    @MaximAlien
    MaximAlien committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    242ee49 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2021

  1. Add defaultAltitude, which is used as part of initial `NavigationCa… 

    …mera` setup process.
    @MaximAlien
    MaximAlien committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    465fb2a View commit details
    Browse the repository at this point in the history

  2. Remove unused CLLocationDegrees extension.

    @MaximAlien
    MaximAlien committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    3fff0f1 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. Add two new public properties: useBearingSmoothing and `maxBearingA… 

    …ngleDiffWhenSmoothing`, which allow to control `NavigationCamera` behavior.
    @MaximAlien
    MaximAlien committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    41d0db0 View commit details
    Browse the repository at this point in the history

  2. Change default value for maxBearingAngleDiffWhenSmoothing.

    @MaximAlien
    MaximAlien committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    dc51870 View commit details
    Browse the repository at this point in the history

  3. Add distanceToFrameAfterManeuver public property.

    @MaximAlien
    MaximAlien committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    c4ee83a View commit details
    Browse the repository at this point in the history

  4. Simplify NavigationViewportDataSource public APIs and improve docum… 

    …entation.
    @MaximAlien
    MaximAlien committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    04694a9 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. Merge branch 'release-v2.0' into maxim/camera-viewport-api

    @MaximAlien
    MaximAlien committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    371729d View commit details
    Browse the repository at this point in the history