Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a possibly not-updating StepsViewController after reroutes #4716

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

kried
Copy link
Contributor

@kried kried commented Sep 5, 2024

Description

https://mapbox.atlassian.net/browse/NAVIOS-1628

Updates route progress in StepsViewController

@kried kried self-assigned this Sep 5, 2024
@kried kried requested a review from a team as a code owner September 5, 2024 08:27
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 60.05%. Comparing base (d3321aa) to head (ae71b2e).
Report is 1 commits behind head on lts/v2.

Files with missing lines Patch % Lines
Sources/MapboxNavigation/StepsViewController.swift 0.00% 8 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##           lts/v2    #4716      +/-   ##
==========================================
+ Coverage   60.03%   60.05%   +0.01%     
==========================================
  Files         189      189              
  Lines       21316    21324       +8     
==========================================
+ Hits        12798    12806       +8     
  Misses       8518     8518              
Files with missing lines Coverage Δ
Sources/MapboxNavigation/StepsViewController.swift 57.45% <0.00%> (-2.09%) ⬇️

... and 2 files with indirect coverage changes

@kried kried merged commit b735475 into lts/v2 Sep 5, 2024
19 checks passed
@kried kried deleted the NAVIOS-1628-steps-instructions branch September 5, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants