Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of initialization of annotation managers matters! #863

Closed
androideveloper opened this issue Mar 5, 2019 · 10 comments · Fixed by #1147
Closed

Order of initialization of annotation managers matters! #863

androideveloper opened this issue Mar 5, 2019 · 10 comments · Fixed by #1147

Comments

@androideveloper
Copy link

I have found a weird bug! When you initialize symbol manager and the circle manager, your symbol can't be dragged! If you change the order of initialization it works!

Steps to reproduce

Demo https://www.dropbox.com/s/ympu7zg722vehty/MapboxSymbolDragDemo.zip?dl=0

Try to change order of initialization:
symbolManager = SymbolManager(mapView, mapboxMap, style)
circleManager = CircleManager(mapView, mapboxMap, style)

Expected behavior

Symbol should be draggable in any case

Actual behavior

Symbol is draggable only, if circle manager initialized first

Configuration

Android versions: 9.0
Device models: Xiaomi mi 2 lite
Mapbox SDK versions: 7.2.0, plugin-annotation-v7:0.5.0

@LukasPaczos
Copy link
Contributor

This is an interesting case, thanks for the report @androideveloper.

Because we are using mapView.setOnTouchListener() to intercept touch events, only the last created manager will have draggable annotations.

There seem to be 2 ways of resolving this:

Will update this ticket with progress, if we find any of above viable.

@androideveloper
Copy link
Author

@LukasPaczos Thanks for the update! I will keep it as the last created manager until this is resolved.

@stale
Copy link

stale bot commented Sep 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the archived Archived by Stale bot. label Sep 18, 2019
@stale
Copy link

stale bot commented Sep 18, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Sep 18, 2019
@langsmith langsmith reopened this Sep 18, 2019
@stale stale bot removed the archived Archived by Stale bot. label Sep 18, 2019
@stale
Copy link

stale bot commented Mar 16, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the archived Archived by Stale bot. label Mar 16, 2020
@stale
Copy link

stale bot commented Mar 17, 2020

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Mar 17, 2020
@adrianababakanian
Copy link

We should re-open this, since recent reports on Stack Overflow indicate that developers are still encountering the issue.

@m0nac0
Copy link

m0nac0 commented May 24, 2020

We're also encountering this in the mapbox_gl flutter plugin (tracked at flutter-mapbox-gl/maps#130). This is kind of significant, as it means that we can only have one draggable annotation type.

@m0nac0
Copy link

m0nac0 commented Jun 15, 2020

@adrianababakanian @LukasPaczos Sorry for spamming, but do you know if this is being worked on? Otherwise we'd have to find some workaround for the mapbox_gl flutter plugin to support draggable annotations.

@virtuoso80
Copy link

Hello. Has there been a workaround for this? My application stops registering drag events after setting mapview.setOnTouchListener(null)
when following this guide https://docs.mapbox.com/android/maps/examples/finger-draw-query/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants