Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation drag event listeners #339

Closed
brizaldi opened this issue Jun 25, 2020 · 9 comments
Closed

Annotation drag event listeners #339

brizaldi opened this issue Jun 25, 2020 · 9 comments
Labels
enhancement New feature or request stale

Comments

@brizaldi
Copy link

is there a way to get a callback when user finished dragging the symbol? kinda similar to Marker.onDragEnd from google_maps_flutter

also in the current version, it seems that we no longer able to drag the symbol, we already set draggable: true inside SymbolOptions

tested on android with mapbox_gl version 0.7.0

@m0nac0
Copy link
Collaborator

m0nac0 commented Jun 25, 2020

@brizaldi Have you been able to drag symbols on an earlier version?
Symbols not being draggable is a known limitation (#130). This is a known issue with the Mapbox Android SDK mapbox/mapbox-plugins-android#863: you can only have one draggable annotation type (symbols, circles or lines).
If you want to drag symbols, you have to clone the repo and change the order of these lines: https://github.com/tobrun/flutter-mapbox-gl/blob/2339ab64c64ff75d544385ae16a35b3998dfc1be/android/src/main/java/com/mapbox/mapboxgl/MapboxMapController.java#L324-L326 The last manager you enable will support dragging.

Drag listeners currently aren't implemented but are a good idea.

@m0nac0 m0nac0 added the enhancement New feature or request label Jun 25, 2020
@brizaldi
Copy link
Author

@m0nac0 is there any plan to include it on next future release of this package? because i think to be able to drag marker is very essential feature for a lot of projects with maps

@m0nac0
Copy link
Collaborator

m0nac0 commented Jun 26, 2020

@brizaldi There's unfortunately not much we can do to fix this in this plugin as it's an issue with the Mapbox Android SDK and we are just wrapping that. There already seems to be a community contributed PR to solve this, but I don't know what the Mapbox team's plans are on this and how complex this issue actually is.
@tobrun Might know more on this, though?

@Ph0tonic
Copy link

This issues has been fixed upstream and released in the latest version 👍

@m0nac0 m0nac0 changed the title Symbol onDragEnd & draggable not working Annotation drag event listeners Aug 14, 2020
@m0nac0
Copy link
Collaborator

m0nac0 commented Aug 14, 2020

@brizaldi As #381 will bring @Ph0tonic's upstream fix for the issue with draggable symbols, I changed the title to track the feature request for drag event listeners.

@lfofelipe
Copy link
Contributor

Can anyone show me the primary aspects to implement this feature?
If someone helps me, I can commit to implementing it.

@lfofelipe
Copy link
Contributor

I really need this function for developing an application in production. Can someone give me some way where I should start to develop this feature or can help me with the development? The case is that I need to update a polygon after getting the coordinates of where the drag (vertex) of a mark (symbol) ended.

@GULERTOLGA
Copy link
Contributor

I've been working on this issue since yesterday. I created a branch for Android. I'll let you know if I can make progress. It may take a day or two.

GULERTOLGA added a commit to GULERTOLGA/flutter-mapbox-gl that referenced this issue Apr 16, 2021
GULERTOLGA added a commit to GULERTOLGA/flutter-mapbox-gl that referenced this issue May 12, 2021
@stale
Copy link

stale bot commented Jan 14, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 14, 2022
@stale stale bot closed this as completed Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

5 participants