Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the sample application for better click on map support #278

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikeringrose
Copy link
Contributor

Description

Updating the sample application to better handle Map onClick events. When a user clicks on a map, the following events will happen:

  1. call queryRenderedFeatures
  2. filter for all features that have an ID
    3a. select the first feature that has an ID and do a retrieve and show the places card
    3b. if no features have id or not features were returned, do a reverse search call and display all POIs on the map

Screenshots or Gifs

Screen_recording_20240906_084745.webm

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR (where applicable)
  • I have run tests and automatic checks locally
  • I have run pitest check locally and checked that the coverage increased (or didn't change) or decreased insignificantly
  • I have made corresponding changes to the documentation (where applicable)
  • I have grouped commits logically or I promise to squash my commits before merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant