Add support for SPM #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederoni
force-pushed
the
spm
branch
6 times, most recently
from
c4a668c
to
744d01f
Compare
1ec5
approved these changes
Jun 5, 2019
There was a problem hiding this comment.
Looks good. Remember to update the CocoaPods podspec to reflect the Swift version change:
mapbox-speech-swift/MapboxSpeech.podspec
Line 45 in 9725f72
mapbox-speech-swift/.swift-version
Line 1 in 9725f72
Hopefully for the last time. 🤞
Merged
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
SPM 5 marks a milestone where it will potentially remove the need for CocoaPods and Carthage in the future with its support for iOS, cross-platform frameworks, and project-less structure.
I don't see any reason to backport SPM compat to before 5 by adding a
Package@swift-4.swift, but from now on, let's treat SPM as a first-class citizen.I also added a CLI
swift run MapboxSpeechCLI "Say something"(Xcode 11 is required on macOS 10.15)cc @1ec5