Api interface vector filtering #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… creating new layers. LayerFilter now extends MapboxDataProperty; CoreVectorLayerProperties registers and unregisters LayerFilters.PropertyHasChanged, called from VectorLayerVisualizer.SetProperties and VectorLayerVisualizer.UpdateVector. Property drawer for filter business now sets LayerFilters.PropertyHasChanged directly.
Renamed DeleteFilter to RemoveFilter to be consistent in API nomenclature GetFilterMethods now return ILayerFilter instead of LayerFilter. Added Get methods for Key, Value, Operator to ILayerFilter. Interacting with filter dropdowns without changing values no longer triggers changes.
…pbox-unity-sdk into api-interface-vector-filtering * 'api-interface-vector-filtering' of github.com:mapbox/mapbox-unity-sdk: Added a RemoveAllFilters method Renamed DeleteFilter to RemoveFilter to be consistent in API nomenclature GetFilterMethods now return ILayerFilter instead of LayerFilter. Added Get methods for Key, Value, Operator to ILayerFilter. Interacting with filter dropdowns without changing values no longer triggers changes. fix a bug in ElevatedTerrainWithSidesStrategy where it didn't compare vertex count properly fix terrain strategies to work well with sample count runtime updates fixes dispose buffer being ignored for RangeAroundTransform Fix UpdateMap lat long Public interfaces for image & terrain layer. Vector layer operations and model api methods (#1036)
|
@greglemonmapbox Please fill out the description and related issues & checklist sections as relevant to this PR. API methods have missing |
…rface-vector-filtering * commit '39a4b99dc4526ec5d6bc8a66030365a4fb3bf3e3': Modifiers publicinterface (#1047) # Conflicts: # sdkproject/Assets/Mapbox/Unity/MeshGeneration/LayerVisualizers/VectorLayerVisualizer.cs
abhishektrip
approved these changes
Oct 3, 2018
There was a problem hiding this comment.
Approving to facilitate testing. @greglemonmapbox Please add summary to all API methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Example: Closes #832. Relates to #832.
Description of changes
Your text here!
QA checklists
<summary>description as well as description of parameters.Reviewers
Tag your reviewer(s). Choose wisely.