Fix SpawnOnMap objects not scaling on zoom #1825
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation never sets a parent, so the references to local position and scale in the `Update` function just refer to global position and rotation. This change sets the `AbstractMap _map` as the parent of the newly instantiated object and sets local scale according against that. For position we set global instead of local position because `GeoToWorldPosition` returns the global position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #1826
Description of changes
The current implementation never sets a parent, so the references to local position and scale in the
Updatefunction just refer to global position and rotation. This change sets theAbstractMap _mapas the parent of the newly instantiated object and sets local scale according against that. For position we set global instead of local position becauseGeoToWorldPositionreturns the global position.QA checklists
<summary>description as well as description of parameters.Reviewers
Tag your reviewer(s). Choose wisely.