Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Do not update geocoder control results on special keys #1104

Open
wants to merge 2 commits into
base: publisher-production
Choose a base branch
from

Conversation

kirach
Copy link

@kirach kirach commented Jan 14, 2016

A small change that prevents geocoder control from autocompleting (and update and re-render results) when special key (like escape, tab, enter, arrow keys) was pressed.

@kirach
Copy link
Author

kirach commented Jan 15, 2016

Guys, any feedback please? Do I need to change/add/remove something?

@jfirebaugh
Copy link
Contributor

I wonder if we can use the input event instead. That would avoid needing to use keyCode which is non-standard, deprecated, and system and implementation dependent.

/cc @tmcw

@tmcw
Copy link
Contributor

tmcw commented Mar 23, 2016

IE compatibility for input is pretty sketchy according to the MDN docs - no support for IE<9, and IE9 doesn't fire input when characters are deleted, which is a pretty common occurrence here.

@davidtheclark davidtheclark changed the base branch from mb-pages to publisher-production January 16, 2019 21:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants