Pass variables to replace tokens in query #248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #218 along with a minor change in node-mapnik
What this does:
mapnik::attributes vars
to the mvt processor.processor::update_tile
to thetile_layer
, so that it can set the variables of its associated query from there (empty if not passed to the processor constructor).(thanks @Algunenano for the advice on the constructor)
This is the patch that would be required in node-mapnik to indeed pass the variables to the datasources. I haven't created a PR yet because it makes little sense until this one approved.