append MASON_STDLIB_VERSION to binary if MASON_CXX_PACKAGE == true #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using actual stdlib version string instead. |
This was referenced Sep 22, 2015
|
Please add documentation for the new variable(s) to README.md. Needs @springmeyer 👀 for the general approach. |
mikemorris
force-pushed
the
mason-cxx-version
branch
from
4f3378d to
cd3e01b
Compare
| MASON_CXX_DUMPVERSION=`${CXX} -dumpversion` | ||
| else | ||
| MASON_CXX_DUMPVERSION=`c++ -dumpversion` | ||
| fi |
There was a problem hiding this comment.
Can we shorten this block to ${CXX:-c++} -dumpversion and directly use it below?
mikemorris
force-pushed
the
mason-cxx-version
branch
from
9d0f2f1 to
7bd7320
Compare
4 tasks
mikemorris
force-pushed
the
mason-cxx-version
branch
from
7bd7320 to
3c627cb
Compare
mikemorris
changed the title
|
On hold per #111 (comment) |
mikemorris
force-pushed
the
mason-cxx-version
branch
2 times, most recently
from
49448b7 to
f402ccc
Compare
respect CXX env var add script to print c++ stdlib version include <string> instead of <ciso646> because of https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65473
mikemorris
force-pushed
the
mason-cxx-version
branch
from
f402ccc to
83ebe76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prospective solution to #111, packages with stdlib ABI compatibility issues can opt-in to publishing/fetching compiler-specific versions.
/cc @danpat @springmeyer