-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wget 1.19.2 build script #521
Conversation
@ingalls - happy to give 👁 . Overall this script is looking good. The main missing piece is that So it looks like you'll also need to package
|
scripts/wget/1.19.2/script.sh
Outdated
|
||
PREFIX=${MASON_PREFIX} \ | ||
CXXFLAGS="${CXXFLAGS}" \ | ||
LDFLAGS="${LDFLAGS} -ldl -lpthread" make install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 23 -> 29 can likely be removed. The reason is that build systems that use ./configure
usually pick up these environment variables automatically, such that they do not need to be sent directly to make
. A good example to follow for a ./configure
based build is harfbuzz: https://github.com/mapbox/mason/blob/master/scripts/harfbuzz/1.4.4-ft/script.sh#L36-L61. In harfbuzz the build variables are setup before ./configure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Removed & Tested
scripts/wget/1.19.2/script.sh
Outdated
|
||
function mason_load_source { | ||
mason_download \ | ||
http://ftp.gnu.org/gnu/wget/wget-1.19.2.tar.gz \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best practice is to do http://ftp.gnu.org/gnu/wget/${MASON_NAME}-${MASON_VERSION}.tar.gz
such that creating new package versions, based on cp -r <this package> <new package
, is easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to install gnutls
and other other deps in the mason_prepare_compile
hook
@springmeyer 👍 As far as I can tell GnuTLS is the only requested library that needs to be installed but I'll go through the wget configuration and double check that this is the case. Reading the docs it looks like gnutls is separate from openssl and does not require it. There is a flag to use openssl instead of gnutls in wget if we want to go that route. For now I've sketched out a script for compiling gnu tls and will see if I can get that up and running |
Interesting. Does
Oh, interesting.
Okay. I presume then that means either gnutls or openssl will be the library that knows where certs are. If we depend on gnutls we'd need to statically link it and provide our own certs. This could get messy. If we depend on openssl we can likely expect linux/osx systems to have a recent enough system openssl to use that (and not have to bundle certs ourself).
Based on the above cert issue, it feels like trying to use system openssl will be an easier route. That said, if gnutls+bundling our own certs is likely feasible, just could be a lot of work/unpredictable amount of time to get it right. |
@ingalls looks like the OS X build is failing with It appears that the problem is that while
I'm open to either, but I don't have the ability to invest in b right now. |
@springmeyer I have no access to a Mac OSX Build environment to play around with this so if I did so would have to get setup with another laptop. So I'd suggest we either merge with it broken and ticket or hold on this ticket until we can have some time to be in the same place? I'm of course partial to (a) as I run mason on my local linux dev machine as well as all our ubuntu docker images. |
@ingalls let's merge. Can you please ticket the OS X issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@ingalls next action is in your court - please merge and ticket OS X (the fact that it does not work yet) when you can. |
First pass at writing a build script for mason. Attempting to add
wget@1.19.2
@springmeyer How far off the mark am I? Would love 👁