Support react@18 #220
Support react@18 #220
Conversation
miafan23
commented
Mar 18, 2024
•
miafan23
commented
- Add react 18 to the allowed peer dependencies
- Bump @mapbox/react-submittable to allow react 18 as peer depemdency
There was a problem hiding this comment.
@miafan23 left a couple of questions! Could you fill out the description of this PR for our future selves? It would be good to know about the necessity of this change, the Jira ticket this is references and the change to react-submittable.
There was a problem hiding this comment.
What's up with these weird snapshot changes?
There was a problem hiding this comment.
Radix changes the id for React 18 for better support of SSR
https://github.com/radix-ui/primitives/blob/main/packages/react/id/src/id.tsx#L10
https://www.radix-ui.com/primitives/docs/guides/server-side-rendering
There was a problem hiding this comment.
Good to know this has been consolidated into the latest version of @testing-library/react!
package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@mapbox/mbx-assembly": "^1.5.0", | ||
| "@mapbox/query-selector-contains-node": "^1.0.0", | ||
| "@mapbox/react-submittable": "^2.1.0-alpha.0", |
There was a problem hiding this comment.
What changes happened here besides the new package name? It's not great adding an alpha dependency if we don't need to.
There was a problem hiding this comment.
Oh, I am just waiting for mapbox/react-submittable#9 to be merged and released
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@mapbox/mr-ui", | |||
| "version": "2.9.0", | |||
| "version": "3.0.0", | |||
There was a problem hiding this comment.
Why is this a major version bump if it still supports 16?
@tristen This is a public repo, I am not sure if we should refer jira ticket here 🤔 |
| await waitFor(() => { | ||
| expect(screen.getByText('Tab 1 content')).toBeInTheDocument(); | ||
| }) |
There was a problem hiding this comment.
These tests sometime failed
