Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new fixture for
From #15 into the branch from #18 to get a feel for things. They feel good overall!
Two concerns that came up:
scripts/dump
command which currently hardcodes the2.1
proto.npm run docs
and saw that updates both theFIXTURES.md
andAPI.md
. I would have expectednpm run build
to update theFIXTURES.md
andnpm run docs
to just updateAPI.md
As far as 🍍 this is somewhat problematic. We should probably not hardcode like I did in #17 because then it is hard to use the script to determine if your resulting
.mvt
fixtures is correctly incorrect. Ideas to solve this are:fixtures/
directories and then rig thescripts/dump
to ingest a fixture folder path and to autmatically find the right.proto
on the system.scripts/dump
parse the file without using the proto by using the--decode_raw
trick I mention at Add script to decode raw tiles #17This also raises the fairly meta question in my mind of: how do we test the fixtures? Should we have a way to assert, as part of the build process, that they contain the exactly wrong data we assume?
cc @mapsam