Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Buffer object with handoff from unique ptr string #147

Merged
merged 4 commits into from
Jul 14, 2018

Conversation

flippmoke
Copy link
Member

Added the ability to return the string as a buffer object instead for async methods with this buffer object handing off the result string rather then copying.

Related issue: #69

/cc @springmeyer @GretaCB

@flippmoke flippmoke requested a review from GretaCB July 6, 2018 16:23
Copy link
Contributor

@GretaCB GretaCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks for pushing this through @flippmoke 🙌

Since this PR adds a new buffer option, could you update the API docs? The skel already has a script that can autogenerate this using documentation.js, and can be run like so:

npm install -g documentation
npm run docs

@flippmoke
Copy link
Member Author

@springmeyer
Copy link
Contributor

@GretaCB getting Unknown argument: polyglot from https://github.com/mapbox/node-cpp-skel/blob/master/package.json#L14

Per chat, this is because you need to install an older documentation-js version. @GretaCB can you make sure it is documented how to install the old version? (since I presume it is a big lift to deal with trying to get the newer version working and not something we have time for).

@springmeyer
Copy link
Contributor

doc issue ticketed at #150 and worked around in f9fa032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants