Overhaul [not ready] #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage
|
Changes Unknown when pulling b1a1329 on overhaul into * on master*. |
|
Changes Unknown when pulling 1456f23 on overhaul into * on master*. |
|
Changes Unknown when pulling 0ca7fc8 on overhaul into * on master*. |
|
Changes Unknown when pulling d67e56b on overhaul into * on master*. |
This was referenced Mar 20, 2015
This was referenced Mar 20, 2015
Closed
|
Changes Unknown when pulling d67e56b on overhaul into * on master*. |
|
Changes Unknown when pulling d67e56b on overhaul into * on master*. |
- avoid allocating std::string and instead keep alive the node.Buffer containing the in-memory font data and use a pointer to its memory - use RAII principles in baton structs for setting up and destroying persistent handles
Load faces from memory rather than disk
|
Changes Unknown when pulling d6035c4 on overhaul into * on master*. |
[overhaul] Fix memory leaks
|
Changes Unknown when pulling feb4a46 on overhaul into * on master*. |
|
Changes Unknown when pulling feb4a46 on overhaul into * on master*. |
|
Changes Unknown when pulling feb4a46 on overhaul into * on master*. |
|
Changes Unknown when pulling feb4a46 on overhaul into * on master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a-and-zthing — there's no need to keep that functionality around, is there?todos for myself:
Closes #77, closes #69
cc @springmeyer