Remove seemingly unused/dead code #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it was added in 485342a, but the code that used it has since been removed. |
|
@springmeyer 👍 from me |
|
Thanks, @mapsam, merging. |
|
@springmeyer I imagine this will need to be a major bump, just in case anyone has begun relying on .utils? Will mark as vNext in the changelog |
|
Aha, we are pre 1.0 so this can just be a minor bump per the pre 1.x semver docs
|
|
Added 6febf74 |
|
Yes, I think this is okay at minor bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that the
utils.jsis not used/tested. Queuing this up to consider removing it unless someone knows that this is in use downstream. If it is, then we'll need tests.