Check if downloaded binary package actually contains a valid lib.node

[recrsn]

Currently node-pre-gyp does not validate whether a downloaded package actually contains a valid compiled binary.

The npm install succeeds as node-pre-gyp assumes all download files have a binary in them. But all breaks when the library is required from a script.

When automating things from travis, it might happen that the node binding file is missing but the file is uploaded, for various reasons. Or the file may incompatible.
This error should be shown in bold warnings.

[reconbot]

It does try to require the module after install to see if it works. This does assume the binary is loaded at the same time.

…

On Sat, Feb 18, 2017, 7:57 PM Amitosh Swain Mahapatra < ***@***.***> wrote: Currently node-pre-gyp does not validate whether a downloaded package actually contains a compiled binary. The npm install succeeds as node-pre-gyp assumes all download files have a binary in them. But all breaks when the library is required from a script. When automating things from travis, it might happen that the node binding file is missing but the file is uploaded, for various reasons. This error should be shown in bold warnings. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#265>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABlbog6101vPHVLxKyyO7rDCzgFPzpuks5rd5OOgaJpZM4MFUGg> .

[recrsn]

Yeah I looked into the code and found that. But for some reason it is not happening with bcrypt