Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Unsupported target versions: Node.js > v17 #710

Closed
cclauss opened this issue Apr 11, 2024 · 2 comments
Closed

Error: Unsupported target versions: Node.js > v17 #710

cclauss opened this issue Apr 11, 2024 · 2 comments

Comments

@cclauss
Copy link
Collaborator

cclauss commented Apr 11, 2024

WORKAROUND: To support newer versions of Node.js > v17

npm ci  # mapbox/node-pre-gyp
npm run update-crosswalk

abi_crosswalk.json must be updated to cover all currently supported versions of Node.js.

Proof:

The testing on this repo fails on all currently supported versions of Node.js but passes on end-of-life versions.

@springmeyer @ewanharris, @mapsam

cclauss added a commit to cclauss/node-pre-gyp that referenced this issue Apr 11, 2024
@ewanharris
Copy link
Contributor

ewanharris commented Apr 11, 2024

@cclauss I think node-pre-gyp can be viewed as having no maintenance due to #657. I was never associated with the package, just made PRs as needed, and since that issue I ended up using patch-package to maintain updates to the abi_crosswalk.json file there, it's not ideal but AFAICT it's the only path forward for users right now.

At 6.5 million weekly downloads and >1000 dependents (across @mapbox/node-pre-gyp and node-pre-gyp) it's clear this package is well used in the ecosystem but given that mapbox no longer uses this software could it potentially be picked up in some manner by the Node.js project? There may be better alternatives now (n-api, prebuild) but I think it's important to avoid this package potentially falling into the wrong hands

@cclauss
Copy link
Collaborator Author

cclauss commented Jun 29, 2024

@cclauss cclauss closed this as completed Jun 29, 2024
cclauss added a commit that referenced this issue Jun 29, 2024
* Fixing issue 647
- Updated abi_crosswalk.json to include node 18 (current).
- Added test coverage for cases of unsupported/unknown targets.

* run.util.js: Test building with msvs 2022

* Update appveyor.yml

* Update appveyor.yml

* Update appveyor.yml

* Update appveyor.yml

* Update appveyor.yml

* Update appveyor.yml

* Update appveyor.yml

* Update appveyor.yml

* Update appveyor.yml

* #710

* update abi_crosswalk.json

* Update appveyor.yml for node 20 support

* test: show command

* Revert "test: show command"

This reverts commit 7804f5c.

* add line ending to abi_crosswalk.json

fix github warning error

* add node 21 to appveyor.yml

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update appveyor.yml

Co-authored-by: Christian Clauss <cclauss@me.com>

* npm run update-crosswalk

Co-authored-by: Christian Clauss <cclauss@me.com>

* npm run update-crosswalk for node 22

* change node 21 to node 22 in appveyor.yml

---------

Co-authored-by: Ron Ilan <github@ronilan.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Ron Ilan <ronilan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants