Pluggable hosting #108

albanm · 2014-08-29T07:22:38Z

Companion project: https://github.com/albanm/node-pre-gyp-hosting-github

The two together are tested in my fork of your node-addon-example project https://github.com/albanm/node-addon-example

I couldn't test that I didn't break s3 support as I don't have an account. I guess travis-ci will tell me soon enough if I did ok.

I didn't externalize s3 hosting in order not to break compatibility, but if you chose to do so it will be easy.

Of course I am open to all feedback.

springmeyer · 2014-08-29T07:57:39Z

Nice work - looking good overall. I'll try to take a closer look soon.

albanm · 2014-08-29T08:36:59Z

Thanks. It seems that the build is broken for node 0.8, but I'm afraid I don't understand the failure.

springmeyer · 2014-08-29T08:47:52Z

don't worry about node v0.8

albanm · 2014-09-12T11:26:49Z

Hello.

No pressure, but did you have time to look into it ?

springmeyer · 2014-09-21T22:40:01Z

not yet, but on my radar!

springmeyer · 2014-09-21T22:41:39Z

lib/util/versioning.js

 }
- opts.host = add_trailing_slash(eval_template(package_json.binary.host,opts));
+ opts.host = opts.host ? add_trailing_slash(eval_template(package_json.binary.host,opts)) : null;


why fallback to null here (and below)?

because host is no longer a required option and add_trailing_slash fails if called on null or undefined.

Okay, makes sense. Can you share what an alternative hosting might look like so I can ponder whether the host related params might be moved around so things are more generic? I worry about having null params making this brittle.

see here for an example: https://github.com/albanm/node-addon-example/blob/master/package.json

I didn't move host around in order not to break compatibility, but following the logic of this PR it should probably be in a 'hosting' object in the 'binary' options. And the add_trailing_slash or other processing should be done in the specific hosting implementation.

springmeyer · 2014-09-21T22:42:44Z

Can you please pull in the latest changes from master? Tests are now refactored and disabled for node v0.8.x so they should be passing. Will be good to confirm everything still works with your changes. Thanks!

albanm · 2014-09-22T20:06:04Z

Here you go!

indieisaconcept · 2015-03-24T11:30:04Z

Is there any intention to continue with this PR? I was about to tackle something similar.

springmeyer · 2015-03-24T16:47:09Z

@indieisaconcept - I would prefer there be tools outside of node-pre-gyp to automate the upload of binaries to custom hosts. This has the advantage of keeping node-pre-gyp simple, but not holding anyone back who thinks of yet another place they would like to store binaries. So, my proposal for how to do this is to write a script that hooks into node-pre-gyp either via command line calls (or programmatically). So you if want to push easily to bintray you could write a pre-gyp-publish-binray command or the like. More details on this at #138 (comment)

indieisaconcept · 2015-03-24T21:02:04Z

@springmeyer thanks. I was considering revising node-pre-gyp to support the notion of publish adapters essentially removing all publish logic other than just simple orchastration.

I was then going to write separate adapters for s3, releases & bintray.

This PR looked like it was going in this direction hence the comment.

I think there is value in pulling s3 out of core though and I like the idea of a standardised way of describing a publish adapter. ( See travis/travis-dpl )

I would like to see adapters having an interface as such.

publish
unpublish
info

On Wed, Mar 25, 2015 at 3:47 AM, Dane Springmeyer
notifications@github.com wrote:

@indieisaconcept - I would be interested in supporting tools outside of node-pre-gyp to automate the upload of binaries to custom hosts. This has the advantage of keeping node-pre-gyp simple, but not holding anyone back who thinks of yet another place they would like to store binaries. So, my proposal for how to do this is to write a script that hooks into node-pre-gyp either via command line calls (or programmatically). So you if want to push easily to bintray you could write a pre-gyp-publish-binray command or the like. More details on this at #138 (comment)

Reply to this email directly or view it on GitHub:
#108 (comment)

albanm · 2015-03-25T09:24:24Z

Hello. One thing this PR does not is: "holding anyone back who thinks of yet another place they would like to store binaries". Quite the contrary actually.

It makes node-pre-gyp pluggable, if the upload logic is already available in a module 'node-bintray' for example, just create a 'node-pre-gyp-hosting-bintray' module that bridges the gap.

If the upload logic is purely specific to a user, just write a 'node-pre-gyp-hosting-custom' plugin with a script loading mechanism and which would accept some parameters similar to this :

"hosting": {
      "provider": "custom",
      "require": "my-script" // Path to the custom user's script
 }

The custom user script would have to implement the 'publish', 'unpublish' and 'download' methods just as other plugins.

Of course you don't have to create a separate 'node-pre-gyp-hosting-custom' project, just bring it with the main project as a officially supported hosting implementation in 'lib/util/hosting-custom.js' alongside with 'lib/util/hosting-s3.js'.

Hope this helps !

bchr02 · 2015-10-01T08:55:08Z

+1 for adding this directly in node-pre-gyp. It seems like it's a basic necessity. I almost didn't notice that the work was done and therefore almost wrote something similar. But more importantly the reason it should be included is because I consider storing binaries in github releases more of the default then S3. If there was one extra api that should be directly integrated into node-pre-gyp this is it.

piranna · 2015-10-27T12:10:38Z

I agree with @bchr02, publish to GitHub is not recommended but it's free, while at the same time S3 is a paid option. As the README says GitHub is just enough for smaill projects, so I think this pull-request should be included and GitHub publishing set as default.

bchr02 · 2015-10-27T12:38:18Z

@piranna So you know, I ended up creating a module that complements node-pre-gyp called node-pre-gyp-github which allows publishing to GitHub releases.

Instead of node-pre-gyp publish you would use node-pre-gyp-github publish

@springmeyer if your not going to add this support, maybe you can update your README.md to mention my module? Thanks.

springmeyer · 2016-10-24T20:42:22Z

Closing since node-pre-gyp-github is the recommended solution and that is now documented at https://github.com/mapbox/node-pre-gyp#host

unknown and others added 2 commits August 28, 2014 13:56

first attempt at externalized hosting implementations

7e4d56b

fixed paths + host being optional

51d08ab

springmeyer reviewed Sep 21, 2014
View reviewed changes

albanm added 2 commits September 22, 2014 20:38

Merge branch 'master' of https://github.com/mapbox/node-pre-gyp

0887b22

try to prevent sending [object Object] string to node-gyp

6fce0ed

albanm mentioned this pull request Oct 1, 2015

Is this repo working? albanm/node-pre-gyp-hosting-github#1

Open

bchr02 mentioned this pull request Oct 8, 2015

Precompiled node-oracle oracle/node-oracledb#18

Closed

lyzidiamond mentioned this pull request Oct 9, 2015

Support tickets in node-pre-gyp updated from Wed Sep 09 2015 to Fri Oct 09 2015 lyzidiamond/mapbox-support#238

Open

5 tasks

springmeyer mentioned this pull request Mar 31, 2016

Cool idea bchr02/node-pre-gyp-github#3

Closed

springmeyer closed this Oct 24, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pluggable hosting #108

Pluggable hosting #108

albanm commented Aug 29, 2014

springmeyer commented Aug 29, 2014

albanm commented Aug 29, 2014

springmeyer commented Aug 29, 2014

albanm commented Sep 12, 2014

springmeyer commented Sep 21, 2014

springmeyer Sep 21, 2014

albanm Sep 22, 2014

springmeyer Sep 22, 2014

albanm Sep 22, 2014

springmeyer commented Sep 21, 2014

albanm commented Sep 22, 2014

indieisaconcept commented Mar 24, 2015

springmeyer commented Mar 24, 2015

indieisaconcept commented Mar 24, 2015

albanm commented Mar 25, 2015

bchr02 commented Oct 1, 2015

piranna commented Oct 27, 2015

bchr02 commented Oct 27, 2015

springmeyer commented Oct 24, 2016

Pluggable hosting #108

Pluggable hosting #108

Conversation

albanm commented Aug 29, 2014

springmeyer commented Aug 29, 2014

albanm commented Aug 29, 2014

springmeyer commented Aug 29, 2014

albanm commented Sep 12, 2014

springmeyer commented Sep 21, 2014

springmeyer Sep 21, 2014

Choose a reason for hiding this comment

albanm Sep 22, 2014

Choose a reason for hiding this comment

springmeyer Sep 22, 2014

Choose a reason for hiding this comment

albanm Sep 22, 2014

Choose a reason for hiding this comment

springmeyer commented Sep 21, 2014

albanm commented Sep 22, 2014

indieisaconcept commented Mar 24, 2015

springmeyer commented Mar 24, 2015

indieisaconcept commented Mar 24, 2015

albanm commented Mar 25, 2015

bchr02 commented Oct 1, 2015

piranna commented Oct 27, 2015

bchr02 commented Oct 27, 2015

springmeyer commented Oct 24, 2016