Fix versioning when runtime is 'node-webkit' but target is empty

[Mithgol]

In my commit 53f3e38 I accidentally neglected the case when target is empty.

This pull request is expected to fix #104, fix TryGhost/node-sqlite3#339, fix the original problem of TryGhost/node-sqlite3#328 and also fix a bunch of other similar node-webkit-related issues occuring in addon-containing modules that use node-pre-gyp.

[springmeyer]

thanks for this fix! In the future please I'd prefer not to increment the version in a pull request since usually it makes more sense to bump the version once pulls have landed in master.

[manhdn]

Hi Mithgold, after copy your new versionsing.js in fix issue Mithgol@756ad4d, it have another error with path.

Uncaught node.js Error
AssertionError: path must be a string
at Module.require (module.js:360:3)
at require (module.js:378:17)
at Object. (C:\Users\Manh\AppData\Local\Temp\nw6428_9924\node_modules\sqlite3\lib\sqlite3.js:4:15)
at Module._compile (module.js:454:26)
at Object.Module._extensions..js (module.js:472:10)
at Module.load (module.js:354:32)
at Function.Module._load (module.js:310:12)
at Module.require (module.js:362:17)
at require (module.js:378:17)
at window.require (:4:17)

My App test still run well if I run nw.exe and source code like: %~dp0/webkit/nw.exe ./src/ (this is run well with sqlite3), but after built and run built node-webkit app it have above issue (both on window8.1 and MacOS)

I'm using

• Nodewebkit: 0.10.5
• node: 0.10.32
• sqlite3 custom build with: node-webkit-v0.10.5-win32-ia32

Please give advice, Thanks!

[manhdn]

Hi Mithgold, It run well now when I renamed the built file from app.exe to nw.exe, seem crazy, just change the name of built file then it can run, don't know why. Thanks you!

[Mithgol]

I know why. That's issue nwjs/nw.js#199 you've encountered.

P. S.   The pseudonym's “Mithgol”, not “Mithgold”. (It's derived from the Sindarin word “gol”, not from the English word “gold”.)