Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependabot config #875

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Update dependabot config #875

merged 1 commit into from
Nov 26, 2024

Conversation

benmccann
Copy link
Collaborator

@benmccann benmccann commented Jul 13, 2024

There are a few issues with the current dependabot config:

  • the first group name is wrong. Bump the github-actions group with 10 updates #874 is updating npm, but it says github-actions
  • we should avoid grouping because it makes it very hard to handle updates. E.g. Bump the github-actions group with 10 updates #874 is failing. If it were ungrouped then we could merge the working ones, but now they're all blocked
  • daily updates of github actions are probably fine as they will be rare. Dependabot hasn't opened any PRs for github actions yet
  • we can skip patch and minor releases. This is the most important thing to change as it generates tons of noise otherwise
  • the comment above the limit is incorrect
  • the limit is currently set to the default limit, which is unnecessary
  • I don't think we need such a low limit if it we're more selective about which updates to attempt

@benmccann benmccann marked this pull request as draft July 23, 2024 18:52
@benmccann benmccann marked this pull request as ready for review July 23, 2024 21:19
@benmccann
Copy link
Collaborator Author

benmccann commented Jul 23, 2024

@cclauss @lukekarrys I tested this PR against my fork and updated it a bit. It should be ready to go now. You can see roughly what PRs it will open by looking at https://github.com/benmccann/node-pre-gyp/pulls - the exception is that the most recent two PRs are from extra dependencies I added to my project to test dependabot's handling of security upgrades, so those won't be opened here. I wanted to verify that dependabot will still open security upgrades for minor/patch versions with these changes and it does indeed do so.

I've also deployed this same dependabot config in other projects now such as https://github.com/chartjs/chartjs-chart-financial/blob/master/.github/dependabot.yml

@cclauss cclauss merged commit 18d5f80 into mapbox:master Nov 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants