Clang tidy fixes #119
Merged
Clang tidy fixes #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkaefer
reviewed
Dec 19, 2024
| @@ -67,7 +67,7 @@ class basic_pbf_builder : public basic_pbf_writer<TBuffer> { | |||
| * @param tag Tag of the field that will be written | |||
| */ | |||
| template <typename P> | |||
| basic_pbf_builder(basic_pbf_writer<TBuffer>& parent_writer, P tag) noexcept : | |||
| basic_pbf_builder(basic_pbf_writer<TBuffer>& parent_writer, P tag) : | |||
There was a problem hiding this comment.
We're removing noexcept here, presumably because it was never actually noexcept in the first place?
There was a problem hiding this comment.
Exactly. It was never noexcept, clang-tidy found that problem. We can not make it noexcept, so we have to remove the noexcept.
Because the class is derived from parent basic_pbf_writer and uses a non-noexcept constructor of that class.
joto
force-pushed
the
clang-tidy-fixes
branch
from
251014b to
c8f8994
Compare
kkaefer
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes for things found by clang-tidy. See individual commits.