Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bench tests #48

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Fix bench tests #48

merged 3 commits into from
Nov 19, 2024

Conversation

greenlaw
Copy link
Contributor

ts-node doesn't play well with "type": "module", so this uses tsx instead, which fixes npm run bench.

AlexanderBelokon
AlexanderBelokon approved these changes Nov 19, 2024
View reviewed changes
Copy link

@AlexanderBelokon AlexanderBelokon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! 🚀

I think npx isn't strictly necessary here, but it's not breaking anything either 🙂

@greenlaw
Copy link
Contributor Author

Thanks @AlexanderBelokon . I removed the npx, was using it due to some local $PATH issues which I've since fixed.

@greenlaw greenlaw merged commit c2ce04c into main Nov 19, 2024
3 checks passed
@greenlaw greenlaw deleted the greenlaw/use-tsx branch November 19, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderBelokon AlexanderBelokon AlexanderBelokon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greenlaw @AlexanderBelokon