first attempt at modularizing #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test case for missing error code addition
Update test for changed data
* Update failing test to fixed with new sphericalmercator * Test appveyor on node 4.4.2 * Remove node v4 test on windows
| bz = data[0].z; | ||
| bx = data[0].x; | ||
| by = data[0].y; | ||
| source.getTile(bz, bx, by, sourceGet); |
There was a problem hiding this comment.
@yhahn - Trying to work out a way to not use source.getTile again, and use what we've already loaded here: https://github.com/mapbox/tilelive-vector/pull/131/files#diff-6d11f931df6358ebec2a997c99b90d66R95
|
^ This is faux-working :( - this typo is causing this to simply repeat: Line 126 in ce14e1a |
|
Closing this to work on one pr to master #127 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yhahn I jumped back on this. Could I borrow your 👀 + 👂 to talk about how to implement most effectively?