Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url.parse usage in tilelive.load is unpredicable on windows (remove?) #40

Open
springmeyer opened this issue Jan 3, 2012 · 1 comment

Comments

@springmeyer
Copy link
Contributor

The fallback to url.parse at https://github.com/mapbox/tilelive.js/blob/master/lib/tilelive.js#L81 fails hard on windows. Possible to consider removing this and requiring both protocol and pathname to be defined in a uri object?

At least on windows not passing uri as an object, but rather as a string leads to invalid and unpredicatable pathname results:

@rowanwins
Copy link

Gday @springmeyer

I was having some issues with this on windows and was able to resolve this for my case using the filepath module so that might be worth some investigation. If you think it looks promising I'm happy to do a bit more investigation and potentially put together the code properly into a pull request.

Cheers
Rowan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants