Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused schemes. #201

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Remove unused schemes. #201

merged 1 commit into from
Nov 4, 2022

Conversation

MaximAlien
Copy link
Contributor

Remove unused schemes.

@MaximAlien MaximAlien requested a review from a team November 3, 2022 15:55
@MaximAlien MaximAlien self-assigned this Nov 3, 2022
@MaximAlien MaximAlien mentioned this pull request Nov 3, 2022
Merged
ShanMa1991
ShanMa1991 approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@ShanMa1991 ShanMa1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could also update the readme doc for the change?

@1ec5
Copy link
Contributor

1ec5 commented Nov 4, 2022

I think we could also update the readme doc for the change?

The readme doesn’t mention schemes at all. We should mention the change in the release notes:

  • Fixed a build failure when installing this library using Carthage.

@1ec5 1ec5 merged commit a6b203e into main Nov 4, 2022
@1ec5 1ec5 deleted the maxim/remove-unused-schemes branch November 4, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShanMa1991 ShanMa1991 ShanMa1991 approved these changes

@1ec5 1ec5 1ec5 approved these changes

Assignees

@MaximAlien MaximAlien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaximAlien @1ec5 @ShanMa1991