Correct index of closest coordinate when rounding up #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite rounding up, clients of this method expect the index to still be rounded down. Both the method and the test have been corrected for consistency with Turf.js.
1ec5
added
bug
op-ex
frederoni
approved these changes
Dec 16, 2018
This was referenced Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients of
LineString.closestCoordinate(to:)expect the resulting index to be rounded down even when the coordinate is rounded up. Both the method and the test have been corrected for consistency with Turf.js. Specifically, the line string in this test fixture has three vertices, not two.This change has the downstream effect of stabilizing
LineString.sliced(from:to:)andLineString.distance(from:to:).Fixes #27. Reverts a noncritical part of mapbox/mapbox-navigation-ios#284.
/cc @frederoni @JThramer