Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON Representations refactor #95

Merged
merged 1 commit into from
Apr 2, 2020
Merged

JSON Representations refactor #95

merged 1 commit into from
Apr 2, 2020

Conversation

Udumft
Copy link
Contributor

@Udumft Udumft commented Mar 13, 2020

Resolves #94

  • removed JSONType and AnyJSONType
  • GeoJSON properties are now [String; Any?] type
  • Implemented encoding and decoding specializations for dictionaries and arrays with Any? type.

94: got rid of JSONtype and AnyJSONType. Implemented encoding and dec…
6217367 
…oding specializations for dictionaries and arrays with `Any?` type.
@Udumft Udumft added op-ex Refactoring, Tech Debt or any other operational excellence work. backwards incompatible changes that break backwards compatibility of public API labels Mar 13, 2020
@Udumft Udumft added this to the v1.0.0 milestone Mar 13, 2020
@Udumft Udumft requested review from frederoni, JThramer and 1ec5 March 13, 2020 15:26
@Udumft Udumft self-assigned this Mar 13, 2020
JThramer
JThramer approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@JThramer JThramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Udumft Udumft merged commit 0054c49 into master Apr 2, 2020
@Udumft Udumft deleted the 94-sane-json-representations branch April 2, 2020 09:48
@1ec5 1ec5 mentioned this pull request May 29, 2020
Closed
@1ec5 1ec5 modified the milestones: v1.0.0, v0.4.0 Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JThramer JThramer JThramer approved these changes

@frederoni frederoni Awaiting requested review from frederoni

@1ec5 1ec5 Awaiting requested review from 1ec5

Assignees

@Udumft Udumft

Labels
backwards incompatible changes that break backwards compatibility of public API op-ex Refactoring, Tech Debt or any other operational excellence work.
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

Sane JSON Representations
3 participants
@Udumft @JThramer @1ec5