Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Comments in Proto File #41

Closed
flippmoke opened this issue Nov 18, 2015 · 1 comment
Closed

Update Comments in Proto File #41

flippmoke opened this issue Nov 18, 2015 · 1 comment
Labels
help wanted
Milestone
v2.0

Comments

@flippmoke
Copy link
Member

While a great amount of text has changed in the version 2 text specification README, the protob file has not been heavily changed. #39

The comments in the file should be updated to match the wording of the specification and more comments could be added to perhaps better explain some fields (or link to their requirements in the the README?)
@flippmoke flippmoke mentioned this issue Nov 18, 2015
Merged
@flippmoke flippmoke added this to the v2.0 milestone Nov 18, 2015
@pnorman
Copy link

pnorman commented Nov 19, 2015

link to their requirements in the the README

I recommend this

flippmoke added a commit that referenced this issue Nov 20, 2015
@flippmoke
Removed the some of the descriptions from protofile to encourage read…
e64f795 
…ing of the specification directly, added comments for what section to look at for some specification sections. closes #41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
2 participants
@pnorman @flippmoke