Added spline types #118
Merged
Added spline types #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not quite sure here for the curved area type how we would enforce that it forms an actual closed segment. We could check that the control points resolved to the same final location + some rules around knots perhaps but this could be complex. Do we even define rules here? Do we mark curves and curved areas as experimental? |
|
The big question I have about this currently is: do we really need a MultiCurve type instead of (or in addition to) just plain Curve? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to encode features as splines of two types, the first being a curve and the other being and area. This is a possible solution for #114. Updates to the
README.mdof the spec have not done yet.