Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mac build #4

Closed
wants to merge 1 commit into from
Closed

add mac build #4

wants to merge 1 commit into from

Conversation

dogboydog
Copy link
Collaborator

@bjorn
Copy link
Member

bjorn commented Dec 22, 2024

I had opted to only USE_SHARED_ZLIB=on because the other libraries depend on stuff installed via Homebrew, and as such are not available on macOS by default.

I think the only thing we still need on #3 is the -DCMAKE_OSX_ARCHITECTURES='${{ matrix.architectures }}' parameter. Maybe you could add that to the ci-macos branch?

@bjorn
Copy link
Member

bjorn commented Dec 22, 2024

I think the only thing we still need on #3 is the -DCMAKE_OSX_ARCHITECTURES='${{ matrix.architectures }}' parameter. Maybe you could add that to the ci-macos branch?

I've copied over those lines and this fixed #3. :-)

@bjorn bjorn closed this Dec 22, 2024
@dogboydog dogboydog deleted the mac_build branch December 23, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dogboydog @bjorn