Flatten Vec<Vec<LayerTile>> to Vec<LayerTile> #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn
commented
Jan 24, 2022
| assert_eq!(tiles[100].gid, 17); | ||
| assert_eq!(tiles[200].gid, 0); | ||
| assert_eq!(tiles[200 + 1].gid, 17); | ||
| assert!(tiles[9900..9999].iter().map(|t| t.gid).all(|g| g == 0)); |
There was a problem hiding this comment.
This is a bit hard to read, but it should be fixed soon when we add Layer.get_tile (#125).
|
Could you add any interface changes to CHANGELOG.md? |
This simplifies code and should be better on memory usage since it is less fragmented. Also added `width` and `height` attributes to `Layer`. Closes mapeditor#54
bjorn
force-pushed
the
flatten-tiles
branch
2 times, most recently
from
af5d86b
to
3b196ee
Compare
aleokdev
approved these changes
Jan 24, 2022
This was referenced Jan 24, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies code and should be better on memory usage since it is less fragmented.
Also added
widthandheightattributes toLayer.Closes #54