Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loader type #193

Merged
merged 10 commits into from
Mar 14, 2022
Merged

Add loader type #193

merged 10 commits into from
Mar 14, 2022

Conversation

aleokdev
Copy link
Contributor

@aleokdev aleokdev commented Mar 10, 2022

Closes #187, and improves the API a lot by doing so. Non-breaking, but deprecates old loading methods.

Copy link
Member

@bjorn bjorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, looks great to me! I guess just README.md and CHANGELOG.md updates missing.

bjorn
bjorn previously approved these changes Mar 11, 2022
@aleokdev aleokdev merged commit 7c072c9 into mapeditor:master Mar 14, 2022
@aleokdev aleokdev deleted the loader branch March 14, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose constructors with a defaulted cache
2 participants