Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native support for Apple Silicon #3707

Closed
Majirefy opened this issue May 17, 2023 · 5 comments
Closed

Add native support for Apple Silicon #3707

Majirefy opened this issue May 17, 2023 · 5 comments
Labels
feature It's a feature, not a bug.

Comments

@Majirefy
Copy link

Since Tiled is now complied in QT 6, I believe it's good time to add native support for Apple Silicon.

Now Tiled is in x86 on macOS, shall we make it a universal app with native support both for x86(Intel) and Apple Silicon Macs?

@Majirefy Majirefy added the feature It's a feature, not a bug. label May 17, 2023
@bjorn
Copy link
Member

bjorn commented May 18, 2023

Yes, good idea! Is this something you can help with? Otherwise I'll have a look into it next week. I just don't have this hardware myself so I won't be able to test it.

@Majirefy
Copy link
Author

Yes, good idea! Is this something you can help with? Otherwise I'll have a look into it next week. I just don't have this hardware myself so I won't be able to test it.

I have M1 Max MacBook Pro, but don't know how I can help with. Any instructions for me to follow? I will do my best!

@bjorn
Copy link
Member

bjorn commented May 18, 2023

Here are the commands being used to compile Tiled for macOS:

- name: Install Qt
run: |
sudo ./dist/install-qt.sh --version ${QT_VERSION} qtbase qtdeclarative qtsvg qtimageformats qttools | tee -a $GITHUB_PATH
sudo ./dist/install-qt.sh --version ${QTCREATOR_VERSION} qtcreator | tee -a $GITHUB_PATH
- name: Setup Qbs
run: |
qbs setup-toolchains --detect
qbs config defaultProfile xcode
- name: Build Zstandard
run: |
git clone --depth 1 -b master https://github.com/facebook/zstd.git
pushd zstd/lib
make libzstd.a
popd
- name: Build Tiled
run: |
qbs install --install-root install config:release qbs.installPrefix:"" projects.Tiled.staticZstd:true
- name: Deploy Qt
run: |
macdeployqt install/Tiled.app -verbose=2
rm -f install/Tiled.app/Contents/PlugIns/tls/libqopensslbackend.dylib
pushd install
ruby ../dist/macos/fixup-install-names.rb

What would need to be added is something like:

@iplanetcn
Copy link

Hope to support apple silicon as soon as possible.

@bjorn
Copy link
Member

bjorn commented Jun 27, 2023

There is now a universal build available at https://github.com/mapeditor/tiled/actions/runs/5393521019 (the macOS 10.14+ artifact). It is not signed + notarized for now, but any testing would be really appreciated!

Edit: Now that the PR was merged, signed and notarized builds are also available at https://github.com/mapeditor/tiled/actions/runs/5398366246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature It's a feature, not a bug.
Projects
None yet
Development

No branches or pull requests

3 participants