Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't rename custom properties in Properties window #772

Closed
evreqe opened this issue Sep 26, 2014 · 13 comments
Closed

Can't rename custom properties in Properties window #772

evreqe opened this issue Sep 26, 2014 · 13 comments
Labels
missing feature It's not just a feature, it's a feature that really should be there!

Comments

@evreqe
Copy link

evreqe commented Sep 26, 2014

This is a problem I have found with the new Properties window in version 0.10.x

After using the Add Property button to add a custom property to an object, I can click on the Value and edit it, but I cannot click on the Property and edit it. I have to remove the custom property then add it again but type in the new name of the property.

The old properties window allowed editing of both the Property and Value.

@bjorn
Copy link
Member

bjorn commented Sep 26, 2014

You're right. I considered this use-case rare enough to not be a serious issue, but of course it would be nice if you could still also rename the property this way.

@bjorn bjorn changed the title Can't edit Property for Custom Properties in Properties window Can't rename custom properties in Properties window Sep 26, 2014
@kheftel-old
Copy link

I've also run into this issue.

Thanks,

Kawika Heftel
Heftel Studios
801-358-9830
http://www.heftelstudios.com

@fontmas
Copy link

fontmas commented Sep 27, 2014

Kheftel, me too!

+1 in this issue...

@bjorn
Copy link
Member

bjorn commented Sep 27, 2014

Wow, why does everybody need to rename their properties? Is this just to fix typos or am I missing something?

@fontmas
Copy link

fontmas commented Sep 27, 2014

Hi Bjorn,

My main reason is because I always need to setup properties for objects(colliders) and often I write wrong the name of custom properties. I'm helping in the development of X-UNITMX(plugin for UNITY 3D), so I created a couple of custom properties can be read in the plugin.

See an example:
image

Other important issue related in editing properties is at issues #515.

Thanks for the creation and maintenance of this awesome map editor tool!

@bjorn bjorn added the missing feature It's not just a feature, it's a feature that really should be there! label Sep 27, 2014
@bjorn
Copy link
Member

bjorn commented Sep 27, 2014

@fontmas Ah, thanks for going into detail. So at least in your case the issue is indeed "typos", but it's quite understandable when the property names are so complex.

Well, I hope I'll have some time to look into this in the next weeks.

@fontmas
Copy link

fontmas commented Sep 27, 2014

@bjorn, sorry about not explain the details of properties.

Is it possible to add "grouped" properties? See the descriptions below.

Each property begins with "Number"-prefab(ex: 0-preafb) is a "group configuration" of a "prefab"(object) that will be instantiated in Unity3D.

Descriptions of the properties:
"0-prefab" - the name of the first prefab that will be instantiated.
"0-prefab add collider" - add in this prefab the collider layout draw in Tiled.
"0-prefab equals position collider" - transfer the position of this collider for the prefab
"0-prefab path" - path inside of Resources folder project in Unity3D where is the prefab file
"0-prefab z depth" - forward position of a prefab created. It's help in creation of 3D games or 2.5D games.

Others general properties:
"create mesh3d" - can be set with true/false values.
"set material color" - can set a configuration color to a material. Value example: 200,128,39,128 (where 200 = Red, 128=Blue, 39=Green and 128=Alpha)
"add component1" - add a script component for this collider.
"add component2" - add a script component for this collider.
"send message1" - broadcast a message to each component attached to this collider object in Unity3D. Useful to call a script's method for setup something. Value example: MyMethodName|'uniqueStringValues'.

@bjorn
Copy link
Member

bjorn commented Sep 27, 2014

@fontmas Well, of course it would be possible to implement it, given time... This feature was requested before as issue #489.

@wayfu
Copy link
Contributor

wayfu commented Sep 28, 2014

If you end up touching that code anyway, it might be nice to implement tabbing through the properties/values (ie tab on a property->focus on its value and select text; tab on a value->focus on the next property and select text [or create a new one if necessary], and shift-tab going backward the same way)

@bjorn
Copy link
Member

bjorn commented Sep 28, 2014

it might be nice to implement tabbing through the properties/values (ie tab on a property->focus on its value, tab on a value, focus on the next property and create one if necessary, and shift-tab going backward the same way)

Hmm, this already seems to work for me, apart from the automatic creation of new properties of course. Once in edit mode, Tab and Shift+Tab move to the next or previous property. When not in edit mode, Tab is more global, but in that case you can use up/down to navigate the properties and press Enter to start editing one.

@kheftel-old
Copy link

I need to rename properties sometimes simply because my needs change during development. I refactor things in the code of my game, and sometimes I need to refactor things in the map format too. Not just typos.

@ncareau
Copy link

ncareau commented Oct 5, 2014

+1 . Would love to rename the properties. We are currently building the base of our engine and often change how we use properties. We also sometime use the property name to store information and need to change it.
Thanks.

@bjorn
Copy link
Member

bjorn commented Aug 31, 2015

I'm closing this since the requested functionality was implemented by pull request #803 and has been out since Tiled 0.11.

It is not optimal since you need to click the rename button with the mouse, so eventually it would make sense to add a shortcut or to look into triggering the dialog by double-clicking the name.

@bjorn bjorn closed this as completed Aug 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing feature It's not just a feature, it's a feature that really should be there!
Projects
None yet
Development

No branches or pull requests

6 participants